Resolve todo's in all modules #11

New issue

Closed

opened 2023-04-11 08:16:26 +00:00 by LunarTides · 0 comments

LunarTides commented

2023-04-11 08:16:26 +00:00

(Migrated from github.com)

ai.js:

_canUseLocation() {
    return false; // TODO: Using is currently broken.

^ No comment

legacy_attack_1() {
    // Todo: Make this more advanced
    ...

^ This todo is already resolved

yesNoQuestion() {
    ret = 'N'; // TODO: Make this whole function better
    ...

^ Should be fixed in #10

card.js

passiveCheck() {
    // TODO: Explain this??
    ...

^ This function should honestly be removed entirely.

functions.js

parseTags() {
    if (i > 0 && str[i - 1] == "\\") { // If there is a backslash before the &, add the & to the string. TODO: Make this actually work
    ...

^ No comment

game.js

endGame() {
    // Todo: Maybe add more stuff here
    ...

^ Have something else happen when the game ends? You're free to remove the todo if you can't think of anything useful.

ai.canUseLocation
ai.legacy_attack_1
ai.yesNoQuestion
card.passiveCheck
functions.parseTags
game.endGame

ai.js: ```js _canUseLocation() { return false; // TODO: Using is currently broken. ``` ^ No comment ```js legacy_attack_1() { // Todo: Make this more advanced ... ``` ^ This todo is already resolved ```js yesNoQuestion() { ret = 'N'; // TODO: Make this whole function better ... ``` ^ Should be fixed in #10 card.js ```js passiveCheck() { // TODO: Explain this?? ... ``` ^ This function should honestly be removed entirely. functions.js ```js parseTags() { if (i > 0 && str[i - 1] == "\\") { // If there is a backslash before the &, add the & to the string. TODO: Make this actually work ... ``` ^ No comment game.js ```js endGame() { // Todo: Maybe add more stuff here ... ``` ^ Have something else happen when the game ends? You're free to remove the todo if you can't think of anything useful. - [x] ai.canUseLocation - [x] ai.legacy_attack_1 - [x] ai.yesNoQuestion - [x] card.passiveCheck - [x] functions.parseTags - [x] game.endGame

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

LunarTides/Hearthstone.js#11

No description provided.

Rows
Columns