Make ids file less fragile #396
Labels
No labels
breaking change
duplicate
good first issue
help wanted
invalid
question
scope: card
scope: docs
scope: game
scope: registry
scope: script
scope: tool
scope: universe
tracker
type: bug
type: card request
type: documentation
type: enhancement
type: improvement
type: parity
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
LunarTides/Hearthstone.js#396
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The
cards/ids.tsfile can easily break. When it does, it becomes pretty much unrecoverable. The only way to recover would be to restore the file using git, or downloading it from the repository. Hearthstone.js should automatically fix this file if it's broken on run.This isn't as big of a problem as I thought. The file only breaks if it causes a TypeScript parsing error, which should only happen if the file is manually changed. (Unless something goes really wrong in the generation code, which should be caught before the commit lands.)
So I'll move this issue to 4.0. I want to seriously try getting 3.0 out in the near future, so some less urgent issues, like this one, will be put on the back burner.