Make ids file less fragile #396

Open
opened 2025-03-25 07:49:18 +00:00 by LunarTides · 1 comment
LunarTides commented 2025-03-25 07:49:18 +00:00 (Migrated from github.com)

The cards/ids.ts file can easily break. When it does, it becomes pretty much unrecoverable. The only way to recover would be to restore the file using git, or downloading it from the repository. Hearthstone.js should automatically fix this file if it's broken on run.

The `cards/ids.ts` file can easily break. When it does, it becomes pretty much unrecoverable. The only way to recover would be to restore the file using git, or downloading it from the repository. Hearthstone.js should automatically fix this file if it's broken on run.
LunarTides commented 2025-12-04 17:30:15 +00:00 (Migrated from github.com)

This isn't as big of a problem as I thought. The file only breaks if it causes a TypeScript parsing error, which should only happen if the file is manually changed. (Unless something goes really wrong in the generation code, which should be caught before the commit lands.)

So I'll move this issue to 4.0. I want to seriously try getting 3.0 out in the near future, so some less urgent issues, like this one, will be put on the back burner.

This isn't as big of a problem as I thought. The file only breaks if it causes a TypeScript parsing error, which should only happen if the file is manually changed. (Unless something goes *really* wrong in the generation code, which should be caught before the commit lands.) So I'll move this issue to 4.0. I want to seriously try getting 3.0 out in the near future, so some less urgent issues, like this one, will be put on the back burner.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
LunarTides/Hearthstone.js#396
No description provided.