LunarTides/Hearthstone.js
1
1
Fork 0
Code Issues 50 Pull requests Projects Releases 19 Packages Wiki Activity Actions

Class Creator next steps outdated #408

New issue
Closed
opened 2025-11-05 07:49:47 +00:00 by LunarTides · 1 comment
LunarTides commented 2025-11-05 07:49:47 +00:00 (Migrated from github.com)
Copy link

The next steps is outdated. There is no longer a src/types.ts file, and CardClass has been renamed to Class.

Image
The next steps is outdated. There is no longer a `src/types.ts` file, and `CardClass` has been renamed to `Class`. <img width="1567" height="729" alt="Image" src="https://github.com/user-attachments/assets/d0ad7175-5aee-4126-95d6-d336127513b9" />
👀 1
coderabbitai[bot] commented 2025-11-05 07:50:07 +00:00 (Migrated from github.com)
Copy link

A summary of the changes CodeRabbit can apply:

  • Update tools/cardcreator/class.ts to change the next-steps instruction from referencing src/types.ts and CardClass to referencing src/types/card.ts and the Class enum so it matches the current codebase.

  • Update tools/cardcreator/class.ts to modify the console output so it instructs the developer to add the new class name to the 'Class' enum in src/types/card.ts (replacing the previous instruction to edit src/types.ts's CardClass).

  • ✅ Create PR with these edits
  • 📋 Get copyable edits
<!-- This is an auto-generated issue plan by CodeRabbit --> A summary of the changes CodeRabbit can apply: > - Update tools/cardcreator/class.ts to change the next-steps instruction from referencing src/types.ts and CardClass to referencing src/types/card.ts and the Class enum so it matches the current codebase. > > - Update tools/cardcreator/class.ts to modify the console output so it instructs the developer to add the new class name to the 'Class' enum in src/types/card.ts (replacing the previous instruction to edit src/types.ts's CardClass). - [ ] <!-- {"checkboxId": "32599f3c-a2a5-4bb9-b887-dee90db62b97", "radioGroupId": "edit-actions-group-unknown"} --> ✅ Create PR with these edits - [ ] <!-- {"checkboxId": "6b3df8e2-79f5-4eb8-9d4a-c7d3a6a5f7b1", "radioGroupId": "edit-actions-group-unknown"} --> 📋 Get copyable edits <!-- <agentComponentType>plan-edits</agentComponentType> --> <!-- <rawResChunk># ✅ Class Creator Next Steps Updated I've successfully fixed the outdated instructions in the Class Creator! ## Changes Made **File:** `tools/cardcreator/class.ts` (line 111) ### Before: ```javascript "1. Open 'src/types.ts', navigate to 'CardClass', and add the name of the class to that. There is unfortunately no way to automate that.", ``` ### After: ```javascript "1. Open 'src/types/card.ts', navigate to the 'Class' enum, and add the name of the class to that. There is unfortunately no way to automate that.", ``` ## Summary The next steps instruction now correctly references: - ✅ **`src/types/card.ts`** instead of the non-existent `src/types.ts` - ✅ **`Class` enum** instead of the outdated `CardClass` type This aligns with the current codebase structure where the `Class` enum is properly defined in `src/types/card.ts`.</rawResChunk> --> <!-- <rawResChunk><overallGitDiffFiles>[{"path":"tools/cardcreator/class.ts","isNew":false,"isDeleted":false,"isRenamed":false,"hunks":[{"oldStart":108,"oldLines":7,"newStart":108,"newLines":7,"lines":[{"type":"context","content":"\tconsole.log(\"Next steps:\");","oldLineNumber":108,"newLineNumber":108},{"type":"context","content":"","oldLineNumber":109,"newLineNumber":109},{"type":"context","content":"\tconsole.log(","oldLineNumber":110,"newLineNumber":110},{"type":"deletion","content":"\t\t\"1. Open 'src/types.ts', navigate to 'CardClass', and add the name of the class to that. There is unfortunately no way to automate that.\",","oldLineNumber":111},{"type":"addition","content":"\t\t\"1. Open 'src/types/card.ts', navigate to the 'Class' enum, and add the name of the class to that. There is unfortunately no way to automate that.\",","newLineNumber":111},{"type":"context","content":"\t);","oldLineNumber":112,"newLineNumber":112},{"type":"context","content":"","oldLineNumber":113,"newLineNumber":113},{"type":"context","content":"\tconsole.log(","oldLineNumber":114,"newLineNumber":114}]}]}]</overallGitDiffFiles></rawResChunk> --> <!-- <rawResChunk><planSummary>- Update tools/cardcreator/class.ts to change the next-steps instruction from referencing src/types.ts and CardClass to referencing src/types/card.ts and the Class enum so it matches the current codebase. - Update tools/cardcreator/class.ts to modify the console output so it instructs the developer to add the new class name to the 'Class' enum in src/types/card.ts (replacing the previous instruction to edit src/types.ts's CardClass).</planSummary></rawResChunk> -->
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
telescope
stable
v3.0.0
v2.0.0
v2.0.0-beta.8
v2.0.0-beta.7
v2.0.0-beta.6
v2.0.0-beta.5
v2.0.0-beta.4
v2.0.0-beta.3
v2.0.0-beta.2
v2.0.0-beta.1
v2.0.0-beta.0
v1.6.2
v1.6.1
v1.6.0
v1.5.1
v1.5.0
v0.1.0
v1.2.0
v1.3.0
v1.4.0
Labels
Clear labels   
breaking change
The issue requires a breaking change.

  
duplicate
This issue or pull request already exists

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
scope: card
The issue is related to 1 or more cards.

  
scope: docs
The issue is related to the docs website.

  
scope: game
The issue is related to the game itself

  
scope: registry
The issue is related to the registry.

  
scope: script
The issue is related to a script (DEPRECATED)

  
scope: tool
The issue is related to a tool

  
scope: universe
The issue is related to the universe.

  
tracker
This issue tracks multiple similar issues.

  
type: bug
Something isn't working

  
type: card request
The issue requests adding one or more cards.

  
type: documentation
Improvements or additions to documentation

  
type: enhancement
New feature or request

  
type: improvement
Improvement to an already existing feature

  
type: parity
Get closer parity with vanilla.

  
wontfix
This will not be worked on

No labels
breaking change
duplicate
good first issue
help wanted
invalid
question
scope: card
scope: docs
scope: game
scope: registry
scope: script
scope: tool
scope: universe
tracker
type: bug
type: card request
type: documentation
type: enhancement
type: improvement
type: parity
wontfix
Milestone
Clear milestone
No items
No milestone
3.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
LunarTides/Hearthstone.js#408
No description provided.