Remove redundant parameters from the discover function #85

Closed
opened 2023-04-30 16:23:29 +00:00 by LunarTides · 0 comments
LunarTides commented 2023-04-30 16:23:29 +00:00 (Migrated from github.com)

Is your feature request related to a problem? Please describe.
The discover function currently has the add_to_hand and clone parameters. These are not really something that should be embedded in the function itself.

Describe the solution you'd like
Remove these parameters and fix all places that used them.

  • Remove parameters
  • Fix source code
  • Fix cards
  • Update wiki

Describe alternatives you've considered
None

Additional context
None

**Is your feature request related to a problem? Please describe.** The discover function currently has the `add_to_hand` and `clone` parameters. These are not really something that should be embedded in the function itself. **Describe the solution you'd like** Remove these parameters and fix all places that used them. - [x] Remove parameters - [x] Fix source code - [x] Fix cards - [x] Update wiki **Describe alternatives you've considered** None **Additional context** None
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
LunarTides/Hearthstone.js#85
No description provided.