Double-digit placeholder id not supported #99

New issue

Closed

opened 2023-05-02 13:32:54 +00:00 by LunarTides · 0 comments

LunarTides commented

2023-05-02 13:32:54 +00:00

(Migrated from github.com)

Describe the bug
The game doesn't support more than 10 placeholders on one card.

This can be easily fixed by fixing the regex from {.} to {.*?}

To Reproduce
Steps to reproduce the behavior:

Create a card with a non single-digit placeholder id. Eg: {10}
Give the placeholder a value.
Give yourself the card.
The placeholder doesn't work.

Expected behavior
The placeholder should be replaced by the value, like it does in a single-digit placeholder id. Eg: {0}

Screenshots
None

Desktop (please complete the following information):

OS: Windows 10
Version: 1.3-dev

Additional context
None

**Describe the bug** The game doesn't support more than 10 placeholders on one card. This can be easily fixed by fixing the regex from `{.}` to `{.*?}` **To Reproduce** Steps to reproduce the behavior: 1. Create a card with a non single-digit placeholder id. Eg: `{10}` 2. Give the placeholder a value. 3. Give yourself the card. 4. The placeholder doesn't work. **Expected behavior** The placeholder should be replaced by the value, like it does in a single-digit placeholder id. Eg: `{0}` **Screenshots** None **Desktop (please complete the following information):** - OS: Windows 10 - Version: 1.3-dev **Additional context** None

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

LunarTides/Hearthstone.js#99

No description provided.

Rows
Columns