WIP: Add enchantments #11

Draft

LunarTides wants to merge 16 commits from enchantments into main

LunarTides commented

2024-05-18 12:17:51 +00:00

(Migrated from github.com)

Some context here.

Since cards should always be changed using enchantments now, blueprints no longer need to exist.

Features

Combine blueprints into cards
Add enchantments

Regressions

The game just crashes for some reason
Heroes don't show health correctly
The Coin just disappears without doing anything when played
The Coin doesn't ever disappear when played
Enchantment assertion fails when attacking a minion with another minion (Intentional, needs dynamic enchantment)
+1 Enchantment applies 3 times to Sheep.

Some context [here](https://github.com/LunarTides/Hearthstone.gd/pull/10#issuecomment-2081535669). Since cards should always be changed using enchantments now, blueprints no longer need to exist. ## Features - [x] Combine blueprints into cards - [x] Add enchantments ## Regressions - [x] The game just crashes for some reason - [ ] Heroes don't show health correctly - [x] The Coin just disappears without doing anything when played - [ ] The Coin doesn't ever disappear when played - [x] Enchantment assertion fails when attacking a minion with another minion (Intentional, needs dynamic enchantment) - [ ] +1 Enchantment applies 3 times to Sheep.

This pull request is marked as a work in progress.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin enchantments:enchantments

git switch enchantments

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff enchantments

git switch enchantments

git rebase main

git switch main

git merge --ff-only enchantments

git switch enchantments

git rebase main

git switch main

git merge --no-ff enchantments

git switch main

git merge --squash enchantments