LunarTides/Hearthstone.js
1
1
Fork 0
Code Issues 50 Pull requests Projects Releases 19 Packages Wiki Activity Actions

Use enums instead of union types #364

Merged
LunarTides merged 6 commits from enums into main 2025-02-17 08:49:36 +00:00
Conversation 1 Commits 6 Files changed 166 +3074 -1974
LunarTides commented 2024-07-10 18:08:06 +00:00 (Migrated from github.com)
Copy link

Closes #378

I like to put what I'm working on out there instead of keeping it on my computer, especially since I'm working on different computers often.

The cards have not been touched yet, and there are still 49 errors outside the cards, and some logic might have broken.

  • Find more union types and destroy them:
    • interact.prompt.useLocation
    • Player.addQuest
  • Make EventListenerMessage enum the return value of the quest callback.
  • Make the card creators work:
    • Lib:
      • Minion
      • Spell
      • Weapon
      • Location
      • Hero
      • Heropower
    • Custom:
      • Minion
      • Spell
      • Weapon
      • Location
      • Hero
      • Heropower
    • Vanilla:
      • Minion
      • Spell
      • Weapon
      • Location
      • Hero
      • Heropower
    • Class
  • Make sure the deck creator works.
  • Make sure the scripts work.
  • Make sure the game works.
Closes #378 I like to put what I'm working on out there instead of keeping it on my computer, especially since I'm working on different computers often. ~~The cards have not been touched yet, and there are still 49 errors outside the cards, and some logic might have broken.~~ - [x] Find more union types and destroy them: - [x] `interact.prompt.useLocation` - [x] `Player.addQuest` - [x] Make `EventListenerMessage` enum the return value of the quest callback. - [x] Make the card creators work: - [x] Lib: - [x] Minion - [x] Spell - [x] Weapon - [x] Location - [x] Hero - [x] Heropower - [x] Custom: - [x] Minion - [x] Spell - [x] Weapon - [x] Location - [x] Hero - [x] Heropower - [x] Vanilla: - [x] Minion - [x] Spell - [x] Weapon - [x] Location - [x] Hero - [x] Heropower - [x] Class - [x] Make sure the deck creator works. - [x] Make sure the scripts work. - [x] Make sure the game works.
LunarTides commented 2025-02-13 11:44:42 +00:00 (Migrated from github.com)
Copy link

Completely rewrote this PR.

Completely rewrote this PR.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
breaking change
The issue requires a breaking change.

  
duplicate
This issue or pull request already exists

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
scope: card
The issue is related to 1 or more cards.

  
scope: docs
The issue is related to the docs website.

  
scope: game
The issue is related to the game itself

  
scope: registry
The issue is related to the registry.

  
scope: script
The issue is related to a script (DEPRECATED)

  
scope: tool
The issue is related to a tool

  
scope: universe
The issue is related to the universe.

  
tracker
This issue tracks multiple similar issues.

  
type: bug
Something isn't working

  
type: card request
The issue requests adding one or more cards.

  
type: documentation
Improvements or additions to documentation

  
type: enhancement
New feature or request

  
type: improvement
Improvement to an already existing feature

  
type: parity
Get closer parity with vanilla.

  
wontfix
This will not be worked on

No labels
breaking change
duplicate
good first issue
help wanted
invalid
question
scope: card
scope: docs
scope: game
scope: registry
scope: script
scope: tool
scope: universe
tracker
type: bug
type: card request
type: documentation
type: enhancement
type: improvement
type: parity
wontfix
Milestone
Clear milestone
No items
No milestone
3.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
LunarTides/Hearthstone.js!364
No description provided.