LunarTides/Hearthstone.js
1
1
Fork 0
Code Issues 50 Pull requests Projects Releases 19 Packages Wiki Activity Actions

Update 1.6 #195

Merged
IsakSkole123 merged 68 commits from develop into main 2023-08-05 17:31:20 +00:00
Conversation 3 Commits 68 Files changed 115 +2498 -985
IsakSkole123 commented 2023-06-09 10:10:38 +00:00 (Migrated from github.com)
Copy link
No description provided.
LunarTides (Migrated from github.com) reviewed 2023-06-22 12:46:26 +00:00
index.js
@ -1,14 +1,14 @@
const rl = require("readline-sync");
LunarTides (Migrated from github.com) commented 2023-06-22 12:46:25 +00:00
Copy link

This does work so remove this

This does work so remove this
LunarTides (Migrated from github.com) requested changes 2023-08-05 17:19:18 +00:00
LunarTides (Migrated from github.com) left a comment
Copy link

Almost done, just some small stuff that needs to be done

Almost done, just some small stuff that needs to be done
cards/Classes/Hunter/Secrets/wandering_monster.js
@ -34,8 +35,14 @@ module.exports = {
LunarTides (Migrated from github.com) commented 2023-08-05 16:56:29 +00:00
Copy link

This should be

attacker.ready();
This should be ```js attacker.ready(); ```
LunarTides (Migrated from github.com) commented 2023-08-05 16:57:41 +00:00
Copy link

A player could, theoretically, attack with a 1 durability weapon, the weapon breaks and the player gets their damage reset to 0. In that case, this needs more work.

A player could, theoretically, attack with a 1 durability weapon, the weapon breaks and the player gets their damage reset to 0. In that case, this needs more work.
cards/Examples/4/5_tick_hooks.js
@ -0,0 +1,54 @@
// Created by Hand
LunarTides (Migrated from github.com) commented 2023-08-05 17:03:44 +00:00
Copy link

Change this to:

self.storage.forEach(unhook => unhook());
Change this to: ```js self.storage.forEach(unhook => unhook()); ```
config/dont-change.json
@ -0,0 +1,28 @@
{
LunarTides (Migrated from github.com) commented 2023-08-05 17:05:07 +00:00
Copy link

Swap done and doing.

Swap `done` and `doing`.
src/interact.js
@ -373,49 +472,11 @@ class Interact {
LunarTides (Migrated from github.com) commented 2023-08-05 17:16:35 +00:00
Copy link

Change Generic to GameLoop

Change `Generic` to `GameLoop`
LunarTides (Migrated from github.com) approved these changes 2023-08-05 17:25:25 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
LunarTides
Labels
Clear labels   
breaking change
The issue requires a breaking change.

  
duplicate
This issue or pull request already exists

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
scope: card
The issue is related to 1 or more cards.

  
scope: docs
The issue is related to the docs website.

  
scope: game
The issue is related to the game itself

  
scope: registry
The issue is related to the registry.

  
scope: script
The issue is related to a script (DEPRECATED)

  
scope: tool
The issue is related to a tool

  
scope: universe
The issue is related to the universe.

  
tracker
This issue tracks multiple similar issues.

  
type: bug
Something isn't working

  
type: card request
The issue requests adding one or more cards.

  
type: documentation
Improvements or additions to documentation

  
type: enhancement
New feature or request

  
type: improvement
Improvement to an already existing feature

  
type: parity
Get closer parity with vanilla.

  
wontfix
This will not be worked on

No labels
breaking change
duplicate
good first issue
help wanted
invalid
question
scope: card
scope: docs
scope: game
scope: registry
scope: script
scope: tool
scope: universe
tracker
type: bug
type: card request
type: documentation
type: enhancement
type: improvement
type: parity
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
LunarTides/Hearthstone.js!195
No description provided.