Add ability to export / import packs #426

Merged

LunarTides merged 13 commits from packager into main

2025-12-06 10:26:22 +00:00

Conversation 4 Commits 13 Files changed 183 +1799 -897

LunarTides commented

2025-12-04 22:42:37 +00:00

(Migrated from github.com)

Copy link

Closes #210

Jesus... This PR has exploded in scope... And has spawned #427 and #428, which are colossal... I'm pretty excited :3

~~Fix importing the same pack twice breaks ids.~~ No longer relevant.
If importing a pack removes a card, or if the game adds a new one, the ids will get mismatched.
- Make ids uuids instead of incrementing numbers.
Allow exporting existing packs, or press n to export a new one.
Add metadata (JSON).
- Game version
- Pack version
- Name (for looking up, should be unique.)
- Authors (String list of authors.)
- Links (Name, link object. E.g. links: { github: "https://github.com/Example/Pack1.hspkg", youtube: "https://youtube.com/@Example" } The youtube one can be a channel name, or a video, it doesn't matter. The links can be whatever.)
- Requires (Depend on other packs / cards (bp uuids) / custom classes or tribes)
- Use package.json for reference.
Add proper packs README.
Make sure it works. (Stress test.)

Closes #210 Jesus... This PR has exploded in scope... *And* has spawned #427 and #428, which are *colossal*... I'm pretty excited :3 - [ ] ~~Fix importing the same pack twice breaks ids.~~ No longer relevant. - [x] If importing a pack removes a card, or if the game adds a new one, the ids will get mismatched. - [x] Make ids uuids instead of incrementing numbers. - [x] Allow exporting existing packs, or press `n` to export a new one. - [x] Add metadata (JSON). - [x] Game version - [x] Pack version - [x] Name (for looking up, should be unique.) - [x] Authors (String list of authors.) - [x] Links (Name, link object. E.g. `links: { github: "https://github.com/Example/Pack1.hspkg", youtube: "https://youtube.com/@Example" }` The youtube one can be a channel name, or a video, it doesn't matter. The links can be whatever.) - [x] Requires (Depend on other packs / cards (bp uuids) / custom classes or tribes) - [x] Use `package.json` for reference. - [x] Add proper packs README. - [x] Make sure it works. (Stress test.)

coderabbitai[bot] commented

2025-12-04 22:42:45 +00:00

(Migrated from github.com)

Copy link

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

75 files out of 182 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch packager

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

(https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)
Mastodon
Reddit
LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

> [!IMPORTANT] > ## Review skipped > > More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. > > 75 files out of 182 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. > > You can disable this status message by setting the `reviews.review_status` to `false` in the CodeRabbit configuration file.   <details> <summary>✨ Finishing touches</summary> - [ ]  📝 Generate docstrings <details> <summary>🧪 Generate unit tests (beta)</summary> - [ ]  Create PR with unit tests - [ ]  Post copyable unit tests in a comment - [ ]  Commit unit tests in branch `packager` </details> </details>   --- Thanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=LunarTides/Hearthstone.js&utm_content=426)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. <details> <summary>❤️ Share</summary> - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code) </details> <sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub>

LunarTides commented

2025-12-05 07:06:10 +00:00

(Migrated from github.com)

Copy link

Because of how much this changes things, especially when I'm so close to 3.0, I can't merge now. I'll move this to 4.0.

LunarTides commented

2025-12-05 12:22:11 +00:00

(Migrated from github.com)

Copy link

Rebased on top of ffeecc4. Let's begin!

Rebased on top of ffeecc4. Let's begin!

LunarTides commented

2025-12-06 10:26:18 +00:00

(Migrated from github.com)

Copy link

YOLO!

Reviewers

No reviewers

Labels

Clear labels

breaking change

The issue requires a breaking change.

duplicate

This issue or pull request already exists

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

question

Further information is requested

scope: card

scope: docs

scope: game

The issue is related to the game itself

scope: registry

The issue is related to the registry.

scope: script

scope: tool

The issue is related to a tool

scope: universe

The issue is related to the universe.

tracker

This issue tracks multiple similar issues.

type: bug

Something isn't working

type: card request

The issue requests adding one or more cards.

type: documentation

Improvements or additions to documentation

type: enhancement

New feature or request

type: improvement

Improvement to an already existing feature

type: parity

Get closer parity with vanilla.

wontfix

This will not be worked on

No labels

Milestone

Clear milestone

No items

No milestone

4.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

LunarTides/Hearthstone.js!426

Reference in a new issue

Repository

LunarTides/Hearthstone.js

Title

Body

No description provided.

Delete branch "packager"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns