LunarTides/Hearthstone.js
1
1
Fork 0
Code Issues 44 Pull requests 1 Projects Releases 19 Packages Wiki Activity Actions

Add ability to export / import packs #426

Merged
LunarTides merged 13 commits from packager into main 2025-12-06 10:26:22 +00:00
Conversation 3 Commits 13 Files changed 183 +1799 -897
LunarTides commented 2025-12-04 22:42:37 +00:00 (Migrated from github.com)
Copy link

Closes #210

Jesus... This PR has exploded in scope... And has spawned #427 and #428, which are colossal... I'm pretty excited :3

  • Fix importing the same pack twice breaks ids. No longer relevant.
  • If importing a pack removes a card, or if the game adds a new one, the ids will get mismatched.
    • Make ids uuids instead of incrementing numbers.
  • Allow exporting existing packs, or press n to export a new one.
  • Add metadata (JSON).
    • Game version
    • Pack version
    • Name (for looking up, should be unique.)
    • Authors (String list of authors.)
    • Links (Name, link object. E.g. links: { github: "https://github.com/Example/Pack1.hspkg", youtube: "https://youtube.com/@Example" } The youtube one can be a channel name, or a video, it doesn't matter. The links can be whatever.)
    • Requires (Depend on other packs / cards (bp uuids) / custom classes or tribes)
    • Use package.json for reference.
  • Add proper packs README.
  • Make sure it works. (Stress test.)
Closes #210 Jesus... This PR has exploded in scope... *And* has spawned #427 and #428, which are *colossal*... I'm pretty excited :3 - [ ] ~~Fix importing the same pack twice breaks ids.~~ No longer relevant. - [x] If importing a pack removes a card, or if the game adds a new one, the ids will get mismatched. - [x] Make ids uuids instead of incrementing numbers. - [x] Allow exporting existing packs, or press `n` to export a new one. - [x] Add metadata (JSON). - [x] Game version - [x] Pack version - [x] Name (for looking up, should be unique.) - [x] Authors (String list of authors.) - [x] Links (Name, link object. E.g. `links: { github: "https://github.com/Example/Pack1.hspkg", youtube: "https://youtube.com/@Example" }` The youtube one can be a channel name, or a video, it doesn't matter. The links can be whatever.) - [x] Requires (Depend on other packs / cards (bp uuids) / custom classes or tribes) - [x] Use `package.json` for reference. - [x] Add proper packs README. - [x] Make sure it works. (Stress test.)
LunarTides commented 2025-12-05 07:06:10 +00:00 (Migrated from github.com)
Copy link

Because of how much this changes things, especially when I'm so close to 3.0, I can't merge now. I'll move this to 4.0.

Because of how much this changes things, especially when I'm so close to 3.0, I can't merge now. I'll move this to 4.0.
LunarTides commented 2025-12-05 12:22:11 +00:00 (Migrated from github.com)
Copy link

Rebased on top of ffeecc4. Let's begin!

Rebased on top of ffeecc4. Let's begin!
LunarTides commented 2025-12-06 10:26:18 +00:00 (Migrated from github.com)
Copy link

YOLO!

YOLO!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
breaking change
The issue requires a breaking change.

  
duplicate
This issue or pull request already exists

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
scope: card
The issue is related to 1 or more cards.

  
scope: docs
The issue is related to the docs website.

  
scope: game
The issue is related to the game itself

  
scope: registry
The issue is related to the registry.

  
scope: script
The issue is related to a script (DEPRECATED)

  
scope: tool
The issue is related to a tool

  
scope: universe
The issue is related to the universe.

  
tracker
This issue tracks multiple similar issues.

  
type: bug
Something isn't working

  
type: card request
The issue requests adding one or more cards.

  
type: documentation
Improvements or additions to documentation

  
type: enhancement
New feature or request

  
type: improvement
Improvement to an already existing feature

  
type: parity
Get closer parity with vanilla.

  
wontfix
This will not be worked on

No labels
breaking change
duplicate
good first issue
help wanted
invalid
question
scope: card
scope: docs
scope: game
scope: registry
scope: script
scope: tool
scope: universe
tracker
type: bug
type: card request
type: documentation
type: enhancement
type: improvement
type: parity
wontfix
Milestone
Clear milestone
No items
No milestone
4.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
LunarTides/Hearthstone.js!426
No description provided.