LunarTides/Hearthstone.js

Fork 0

Add pack registry #434

Merged

LunarTides merged 66 commits from registry into main

2025-12-26 11:53:15 +00:00

LunarTides commented

2025-12-06 12:21:50 +00:00

(Migrated from github.com)

Closes #427

I have a few ideas about what features the registry can support:

Necessary

These are absolutely necessary for this PR to land.

Packs
- Add Pack db column.
- Parse meta.jsonc.
- Add fields to the row.
- Add likes.
- Add dislikes.
- Allow showing the code in packs.
- Approved by. Allows seeing who approved the version.
- Self-moderation
  - Edit
    - Allow changing metadata from the pack page.
  - Delete
    - Versions
      - Handle deleting all versions manually.
    - All
- Moderation
  - Un(list)
- Reporting
Cards
- Add Card db column.
- Add card representation. See how it looks like in Hearthstone.js, and Vanilla, as an actual card.
  - Parse color tags.
- Reporting
Searching
- Search packs by uuid or name.
- Search cards by uuid or name.
  - Show the pack the card is from.
  - Order by download count.
- Add support for searching in-game.
Add versions.
- Add versions for packs.
- Add versions for cards.
- Add isLatestVersion on packs / cards.
- Make pack names non-unique for packs with the same uuid.
- Validate semver for pack version.
- Save packs to /static/assets/packs/{packUUID}/{packVersion}/{packUUID}.7z
Download.
- Route / API
- Disallow accessing /static/assets directly.
- Add download count.
- Add support for downloading in-game.
Upload
- Parse blueprints after extracting pack.
- Add all bp fields to the row.
- Connect authors to accounts if possible. Allow connecting author accounts after the fact on the pack's page.
- Add limiting who can edit the pack.
- Add support for uploading in-game.
Bugs
- Search packs doesn't show loading, it waits for the result before loading the page.
Other
- TODO
  - Upload
    - Parse enchantment priority correctly.
    - Guard against symlinks.
    - Guard against zip bombs.
    - Validate metadata with zod.
    - Reject proprietary packs.
    - Delete pack from db if adding cards goes wrong.
    - Validate card (blueprint) with zod.
    - Add support for links.
  - Search filter packs by approved.
  - Make searching smarter.
  - Add pagination to search frontend.
  - Color names / rarity of cards by their rarity.
  - Show heropowers in cards.
  - Add proper support for requires.
- Add components folder for easy reuse.
- Add proper API so that it can be queried from the game.
- Add links to the other pages (#428 #435)
- Add new CI workflow for the website.
Moderation tools
- Add approving packs (toggleable)

Extra

These will still be done, but they're less important.

Profile
- About me, pronouns, etc...
- See packs ~~and cards~~
  - Waiting for approval tag.
- Reporting
- Self-moderation
  - Delete account
- Moderation tools
  - Delete pack
  - Rename pack
  - Ban account
  - ...
Comments
- Add support for commenting on:
  - Packs
    - Display comments
    - Like comments
    - Post comment
    - Authors can heart comments on their profile. (Can NOT delete.)
  - Cards
    - Authors can heart comments on their profile. (Can NOT delete.)
  - User profile
    - User can delete / heart comments on their profile.
- Likes
- Reporting
- Self-moderation.
- Moderation.
Notifications
- Your pack has been approved! (Click to view)
- You have been given moderator status.
- You have been mentioned in the comments of a pack.
Moderation tools
- Add review tools for approving packs.
  - GitHub-style tree to view files and folders. Click on the left to copy link. (Use # navigation.)
    - Internal notes. (This line looks suspicious. Can you look at it @ExampleModerator?)
- Dashboard.
  - Search
  - Delete pack
  - Rename pack
  - Ban account
    - Delete comments or orphan them (show commenter as "Deleted User").
  - Settings
    - Page size
    - Enable approve system
    - Max pack size
    - Max pack file amount
    - Pack allowed extensions
    - ...
  - ...
- Event system. Alert moderator when an event happens. This is so that I get alerted every time someone uploads a pack, so that I can review it. (RSS feed?)
  - Discord bot?

Summary by CodeRabbit

New Features
- Added comprehensive pack and card registry site with user authentication, pack uploads, and versioning.
- Added search functionality for packs and cards.
- Added user profiles, comments, and like/dislike interactions for packs.
- Added admin/moderator dashboard for pack approval and management.
- Added notifications system for user interactions.
Dependencies
- Added 7zip-min for archive handling; removed strip-ansi dependency.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Closes #427 I have a few ideas about what features the registry can support: ### Necessary > These are absolutely necessary for this PR to land. - [x] Packs - [x] Add `Pack` db column. - [x] Parse `meta.jsonc`. - [x] Add fields to the row. - [x] Add likes. - [x] Add dislikes. - [x] Allow showing the code in packs. - [x] Approved by. Allows seeing who approved the version. - [ ] Self-moderation - [ ] Edit - [ ] Allow changing metadata from the pack page. - [x] Delete - [x] Versions - [ ] Handle deleting all versions manually. - [x] All - [ ] Moderation - [ ] Un(list) - [ ] Reporting - [x] Cards - [x] Add `Card` db column. - [ ] Add card representation. See how it looks like in Hearthstone.js, and Vanilla, as an actual *card*. - [ ] Parse color tags. - [ ] Reporting - [x] Searching - [x] Search packs by uuid or name. - [x] Search cards by uuid or name. - [x] Show the pack the card is from. - [x] Order by download count. - [ ] Add support for searching in-game. - [x] Add versions. - [x] Add versions for packs. - [x] Add versions for cards. - [x] Add `isLatestVersion` on packs / cards. - [x] Make pack names non-unique for packs with the same uuid. - [x] Validate semver for pack version. - [x] Save packs to `/static/assets/packs/{packUUID}/{packVersion}/{packUUID}.7z` - [x] Download. - [x] Route / API - [x] Disallow accessing `/static/assets` directly. - [x] Add download count. - [ ] Add support for downloading in-game. - [x] Upload - [x] Parse blueprints after extracting pack. - [x] Add *all* bp fields to the row. - [ ] Connect authors to accounts if possible. Allow connecting author accounts after the fact on the pack's page. - [ ] Add limiting who can edit the pack. - [ ] Add support for uploading in-game. - [ ] Bugs - [ ] Search packs doesn't show loading, it waits for the result before loading the page. - [ ] Other - [ ] TODO - [ ] Upload - [ ] Parse enchantment priority correctly. - [ ] Guard against symlinks. - [ ] Guard against zip bombs. - [ ] Validate metadata with zod. - [ ] Reject proprietary packs. - [ ] Delete pack from db if adding cards goes wrong. - [ ] Validate card (blueprint) with zod. - [ ] Add support for links. - [x] Search filter packs by approved. - [ ] Make searching smarter. - [ ] Add pagination to search frontend. - [ ] Color names / rarity of cards by their rarity. - [ ] Show heropowers in cards. - [ ] Add proper support for requires. - [ ] Add components folder for easy reuse. - [x] Add proper API so that it can be queried from the game. - [ ] Add links to the other pages (#428 #435) - [ ] Add new CI workflow for the website. - [ ] Moderation tools - [x] Add approving packs (toggleable) ### Extra > These will still be done, but they're less important. - [x] Profile - [x] About me, pronouns, etc... - [x] See packs ~~and cards~~ - [x] Waiting for approval tag. - [ ] Reporting - [ ] Self-moderation - [ ] Delete account - [ ] Moderation tools - [ ] Delete pack - [ ] Rename pack - [ ] Ban account - [ ] ... - [ ] Comments - [ ] Add support for commenting on: - [x] Packs - [x] Display comments - [x] Like comments - [x] Post comment - [x] Authors can heart comments on their profile. (Can NOT delete.) - [ ] Cards - [ ] Authors can heart comments on their profile. (Can NOT delete.) - [ ] User profile - [ ] User can delete / heart comments on their profile. - [x] Likes - [ ] Reporting - [x] Self-moderation. - [ ] Moderation. - [x] Notifications - [x] Your pack has been approved! (Click to view) - [x] You have been given moderator status. - [ ] You have been mentioned in the comments of a pack. - [ ] Moderation tools - [x] Add review tools for approving packs. - [ ] GitHub-style tree to view files and folders. Click on the left to copy link. (Use # navigation.) - [ ] Internal notes. (This line looks suspicious. Can you look at it @ExampleModerator?) - [ ] Dashboard. - [ ] Search - [ ] Delete pack - [ ] Rename pack - [ ] Ban account - [ ] Delete comments or orphan them (show commenter as "Deleted User"). - [ ] Settings - [ ] Page size - [ ] Enable approve system - [ ] Max pack size - [ ] Max pack file amount - [ ] Pack allowed extensions - [ ] ... - [ ] ... - [x] Event system. Alert moderator when an event happens. This is so that I get alerted every time someone uploads a pack, so that I can review it. (RSS feed?) - [ ] Discord bot?  ## Summary by CodeRabbit * **New Features** * Added comprehensive pack and card registry site with user authentication, pack uploads, and versioning. * Added search functionality for packs and cards. * Added user profiles, comments, and like/dislike interactions for packs. * Added admin/moderator dashboard for pack approval and management. * Added notifications system for user interactions. * **Dependencies** * Added `7zip-min` for archive handling; removed `strip-ansi` dependency. ✏️ Tip: You can customize this high-level summary in your review settings.

coderabbitai[bot] commented

2025-12-06 12:21:55 +00:00

(Migrated from github.com)

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Introduces a comprehensive web-based pack registry system under sites/registry/ with PostgreSQL database, token-based authentication, REST API endpoints, and Svelte UI components. Updates root tooling to support 7zip compression and Bun's native ANSI stripping.

Changes

Cohort / File(s)	Summary
Root Configuration Updates `.gitignore`, `biome.json`, `package.json`, `tsconfig.json`	Added packs archive patterns to gitignore; excluded sites directories from linter; updated dependencies (added 7zip-min, removed strip-ansi/typescript/generate-changelog); updated TypeScript config (esnext target, module preservation).
Tooling Updates `src/functions/color.ts`, `tools/packager.ts`	Replaced strip-ansi with Bun.stripANSI; refactored packager to support 7zip compression, UUID-based pack identification, metadata discovery, and unpacking workflows.
Registry Site Configuration `sites/registry/.env.example`, `.gitignore`, `.npmrc`, `.prettierignore`, `.prettierrc`, `compose.yaml`, `drizzle.config.ts`, `eslint.config.js`, `package.json`, `svelte.config.js`, `tsconfig.json`, `vite.config.ts`	Established project scaffolding with Docker Compose PostgreSQL setup, Drizzle ORM configuration, ESLint/Prettier styling rules, SvelteKit + Vite build tooling.
Database Schema & Server Utilities `sites/registry/src/lib/db/schema.ts`, `src/lib/db/index.ts`, `src/lib/db/pack.ts`, `src/lib/db/comment.ts`, `src/lib/db/setting.ts`	Defined comprehensive Drizzle schema (users, sessions, packs, cards, comments, notifications); implemented data loaders with access control, like/dislike aggregation, and setting management.
Authentication & Authorization `sites/registry/src/lib/server/auth.ts`, `src/lib/user.ts`, `src/lib/pack.ts`	Implemented token-based session management (generation, validation, renewal, cookie handling); added role-based access control helpers and pack/user censoring utilities.
API Routes: Authentication & Users `sites/registry/src/routes/api/v1/user/login/+server.ts`, `register/+server.ts`, `[uuid]/+server.ts`, `sites/registry/src/routes/+page.server.ts`	Provided login/registration endpoints with Argon2 password hashing, user profile management with role changes and notifications, and logout handler.
API Routes: Pack Operations `sites/registry/src/routes/api/v1/pack/[uuid]/+server.ts`, `upload/+server.ts`, `like/+server.ts`, `dislike/+server.ts`	Implemented pack CRUD (delete), file upload with 7z validation and archive inspection, pack like/dislike interactions with per-user state tracking.
API Routes: Pack Versions & Downloads `sites/registry/src/routes/api/v1/pack/[uuid]/versions/[version]/+server.ts`, `approve/+server.ts`, `cards/+server.ts`, `download/+server.ts`, `files/+server.ts`, `files/[...path]/+server.ts`	Exposed version management (delete, approve with notifications), card listing, archive download with 7zip compression, and recursive file tree retrieval.
API Routes: Comments & Interactions `sites/registry/src/routes/api/v1/pack/[uuid]/comments/+server.ts`, `[commentId]/+server.ts`, `[commentId]/like/+server.ts`, `[commentId]/dislike/+server.ts`, `[commentId]/heart/+server.ts`	Implemented paginated comment posting/deletion, like/dislike toggles, and heart (favorite) interactions with author notifications.
API Routes: Search & Notifications `sites/registry/src/routes/api/v1/search/packs/+server.ts`, `cards/+server.ts`, `notifications/+server.ts`, `[uuid]/+server.ts`, `clear/+server.ts`, `feeds/packs/waiting-for-approval.xml/+server.ts`	Built search endpoints (packs/cards by name with pagination), notification fetch/delete/clear, and moderator RSS feed for approval queue.
Shared UI Components `sites/registry/src/lib/components/badge.svelte`, `card-big.svelte`, `card-small.svelte`, `file-tree.svelte`, `pack-big.svelte`, `pack-small.svelte`, `user-big.svelte`	Created reusable Svelte components for cards, packs, users, file browsers, and badges with conditional rendering for metadata, stats, and moderation controls.
Page Routes: Authentication & Dashboard `sites/registry/src/routes/login/+page.server.ts`, `+page.svelte`, `dashboard/**/+layout.server.ts`, `dashboard/packs/+page.svelte`, `dashboard/admin/settings/+page.svelte`	Provided login form with superforms validation, moderator/admin role guards, and dashboard shell pages.
Page Routes: Pack Detail & Versions `sites/registry/src/routes/pack/[uuid]/+layout.server.ts`, `+page.server.ts`, `+page.svelte`, `versions/+page.svelte`, `versions/[version]/+layout.server.ts`, `versions/[version]/+layout.svelte`, `versions/[version]/+page.svelte`, `versions/[version]/files/+page.server.ts`, `versions/all/+page.server.ts`	Implemented pack detail pages with comment threads, version browsing, file tree exploration, like/dislike actions, and version deletion/approval workflows.
Page Routes: Card & User Profiles `sites/registry/src/routes/card/[uuid]/+layout.server.ts`, `+page.svelte`, `versions/+page.svelte`, `versions/[version]/+page.svelte`, `user/[uuid]/+layout.server.ts`, `+page.server.ts`, `+page.svelte`	Created card detail pages with version history, and user profile pages showing packs and metadata with edit controls.
Page Routes: Search & Notifications `sites/registry/src/routes/search/+page.server.ts`, `+page.svelte`, `notifications/+page.server.ts`, `+page.svelte`, `[uuid]/+page.server.ts`	Built search results page with packs/cards, and notifications listing with delete/clear actions.
Page Routes: Upload & Layout `sites/registry/src/routes/upload/+page.server.ts`, `+page.svelte`, `+layout.server.ts`, `+layout.svelte`, `+page.svelte`, `app.d.ts`, `app.html`, `hooks.server.ts`, `layout.css`	Added pack upload form, global layout with navigation, user avatar display, notifications bell, search bar, and session middleware for auth/settings initialization.
Static Assets `sites/registry/static/robots.txt`	Added SEO-friendly robots.txt allowing all user agents.

Sequence Diagram(s)

sequenceDiagram
    actor User
    participant Client as Browser
    participant Server as SvelteKit Server
    participant DB as PostgreSQL
    participant FS as File System

    rect rgba(100, 200, 100, 0.1)
    note over User,FS: Pack Upload Flow
    User->>Client: Select .7z file
    Client->>Server: POST /api/v1/pack/[uuid]/upload (binary)
    Server->>Server: Validate magic bytes (7z)
    Server->>FS: Extract archive to temp dir
    Server->>Server: Validate archive contents<br/>(meta.jsonc, max files, size)
    Server->>Server: Parse metadata & cards
    Server->>DB: Check existing pack versions
    alt New Pack
        Server->>DB: Insert pack + cards records
        Server->>DB: Set isLatestVersion=true
    else Existing Pack (newer version)
        Server->>DB: Mark old versions isLatestVersion=false
        Server->>DB: Insert new pack + cards
        Server->>DB: Set new as isLatestVersion=true
    end
    Server->>FS: Move archive to static/assets/packs/
    Server->>Client: Return 200 with pack metadata
    end

    rect rgba(100, 150, 200, 0.1)
    note over User,FS: Pack Approval Flow (Moderator)
    User->>Client: View waiting-for-approval feed
    Client->>Server: GET /api/v1/feeds/packs/waiting-for-approval.xml
    Server->>DB: Query packs WHERE approved=false
    Server->>Client: Return RSS feed
    User->>Client: Click approve on pack version
    Client->>Server: POST /api/v1/pack/[uuid]/versions/[version]/approve
    Server->>Server: Check moderator role
    Server->>DB: Update pack approved=true, approvedBy=userId
    Server->>DB: Cascade mark previous versions isLatestVersion=false
    Server->>DB: Create notifications for pack authors
    Server->>Client: Return 200
    end

    rect rgba(200, 100, 100, 0.1)
    note over User,FS: Authentication Flow
    User->>Client: Submit login form
    Client->>Server: POST /api/v1/user/login
    Server->>DB: Query user by username
    alt User Not Found
        Server->>Client: 403 Forbidden
    else User Found
        Server->>Server: Verify password (Argon2)
        alt Password Invalid
            Server->>Client: 403 Forbidden
        else Password Valid
            Server->>Server: generateSessionToken()
            Server->>DB: createSession(token, userId)
            Server->>Client: Set auth-session cookie
            Server->>Client: 200 with user data
        end
    end
    end

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~120 minutes

#427: Directly implements the "Add npm-like registry for packs" feature with database schema, authentication, pack/card management, search, upload/download, moderation tools, and approval workflows.

#438: Both PRs modify tools/packager.ts to handle 7zip-based pack discovery, import/export, and compression workflows.

Suggested labels

scope: feature

🐰 A registry is born, with cards and packs so fine,
Users upload their creations, moderation makes them shine,
Comments flow and hearts abound, versions tagged with care,
From database to interface, a marketplace so fair!

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch registry

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 89102c8f36 and 34fec4be0b.

⛔ Files ignored due to path filters (3)

bun.lock is excluded by !**/*.lock
sites/registry/bun.lock is excluded by !**/*.lock
sites/registry/src/lib/assets/favicon.svg is excluded by !**/*.svg

📒 Files selected for processing (108)

.gitignore
biome.json
package.json
sites/registry/.env.example
sites/registry/.gitignore
sites/registry/.npmrc
sites/registry/.prettierignore
sites/registry/.prettierrc
sites/registry/README.md
sites/registry/compose.yaml
sites/registry/drizzle.config.ts
sites/registry/eslint.config.js
sites/registry/package.json
sites/registry/src/app.d.ts
sites/registry/src/app.html
sites/registry/src/hooks.server.ts
sites/registry/src/lib/api/schemas.ts
sites/registry/src/lib/api/types.ts
sites/registry/src/lib/components/badge.svelte
sites/registry/src/lib/components/card-big.svelte
sites/registry/src/lib/components/card-small.svelte
sites/registry/src/lib/components/file-tree.svelte
sites/registry/src/lib/components/pack-big.svelte
sites/registry/src/lib/components/pack-small.svelte
sites/registry/src/lib/components/user-big.svelte
sites/registry/src/lib/db/schema.ts
sites/registry/src/lib/index.ts
sites/registry/src/lib/pack.ts
sites/registry/src/lib/server/auth.ts
sites/registry/src/lib/server/db/comment.ts
sites/registry/src/lib/server/db/index.ts
sites/registry/src/lib/server/db/pack.ts
sites/registry/src/lib/server/db/setting.ts
sites/registry/src/lib/user.ts
sites/registry/src/routes/+layout.server.ts
sites/registry/src/routes/+layout.svelte
sites/registry/src/routes/+page.server.ts
sites/registry/src/routes/+page.svelte
sites/registry/src/routes/api/v1/feeds/packs/waiting-for-approval.xml/+server.ts
sites/registry/src/routes/api/v1/notifications/+server.ts
sites/registry/src/routes/api/v1/notifications/[uuid]/+server.ts
sites/registry/src/routes/api/v1/notifications/clear/+server.ts
sites/registry/src/routes/api/v1/pack/[uuid]/+server.ts
sites/registry/src/routes/api/v1/pack/[uuid]/comments/+server.ts
sites/registry/src/routes/api/v1/pack/[uuid]/comments/[commentId]/+server.ts
sites/registry/src/routes/api/v1/pack/[uuid]/comments/[commentId]/dislike/+server.ts
sites/registry/src/routes/api/v1/pack/[uuid]/comments/[commentId]/heart/+server.ts
sites/registry/src/routes/api/v1/pack/[uuid]/comments/[commentId]/like/+server.ts
sites/registry/src/routes/api/v1/pack/[uuid]/dislike/+server.ts
sites/registry/src/routes/api/v1/pack/[uuid]/like/+server.ts
sites/registry/src/routes/api/v1/pack/[uuid]/upload/+server.ts
sites/registry/src/routes/api/v1/pack/[uuid]/versions/[version]/+server.ts
sites/registry/src/routes/api/v1/pack/[uuid]/versions/[version]/approve/+server.ts
sites/registry/src/routes/api/v1/pack/[uuid]/versions/[version]/cards/+server.ts
sites/registry/src/routes/api/v1/pack/[uuid]/versions/[version]/download/+server.ts
sites/registry/src/routes/api/v1/pack/[uuid]/versions/[version]/files/+server.ts
sites/registry/src/routes/api/v1/pack/[uuid]/versions/[version]/files/[...path]/+server.ts
sites/registry/src/routes/api/v1/search/cards/+server.ts
sites/registry/src/routes/api/v1/search/packs/+server.ts
sites/registry/src/routes/api/v1/user/[uuid]/+server.ts
sites/registry/src/routes/api/v1/user/login/+server.ts
sites/registry/src/routes/api/v1/user/register/+server.ts
sites/registry/src/routes/card/[uuid]/+layout.server.ts
sites/registry/src/routes/card/[uuid]/+page.svelte
sites/registry/src/routes/card/[uuid]/versions/+page.svelte
sites/registry/src/routes/card/[uuid]/versions/[version]/+page.svelte
sites/registry/src/routes/dashboard/+layout.server.ts
sites/registry/src/routes/dashboard/+layout.svelte
sites/registry/src/routes/dashboard/admin/+layout.server.ts
sites/registry/src/routes/dashboard/admin/settings/+page.svelte
sites/registry/src/routes/dashboard/packs/+page.svelte
sites/registry/src/routes/layout.css
sites/registry/src/routes/login/+page.server.ts
sites/registry/src/routes/login/+page.svelte
sites/registry/src/routes/notifications/+page.server.ts
sites/registry/src/routes/notifications/+page.svelte
sites/registry/src/routes/notifications/[uuid]/+page.server.ts
sites/registry/src/routes/pack/[uuid]/+layout.server.ts
sites/registry/src/routes/pack/[uuid]/+page.server.ts
sites/registry/src/routes/pack/[uuid]/+page.svelte
sites/registry/src/routes/pack/[uuid]/comments/+page.server.ts
sites/registry/src/routes/pack/[uuid]/comments/[commentId]/+page.server.ts
sites/registry/src/routes/pack/[uuid]/edit/+page.svelte
sites/registry/src/routes/pack/[uuid]/versions/+page.svelte
sites/registry/src/routes/pack/[uuid]/versions/[version]/+layout.server.ts
sites/registry/src/routes/pack/[uuid]/versions/[version]/+layout.svelte
sites/registry/src/routes/pack/[uuid]/versions/[version]/+page.server.ts
sites/registry/src/routes/pack/[uuid]/versions/[version]/+page.svelte
sites/registry/src/routes/pack/[uuid]/versions/[version]/files/+page.server.ts
sites/registry/src/routes/pack/[uuid]/versions/[version]/files/[...path]/+page.server.ts
sites/registry/src/routes/pack/[uuid]/versions/[version]/files/[...path]/+page.svelte
sites/registry/src/routes/pack/[uuid]/versions/all/+page.server.ts
sites/registry/src/routes/pack/[uuid]/versions/all/+page.svelte
sites/registry/src/routes/search/+page.server.ts
sites/registry/src/routes/search/+page.svelte
sites/registry/src/routes/upload/+page.server.ts
sites/registry/src/routes/upload/+page.svelte
sites/registry/src/routes/user/[uuid]/+layout.server.ts
sites/registry/src/routes/user/[uuid]/+page.server.ts
sites/registry/src/routes/user/[uuid]/+page.svelte
sites/registry/src/routes/user/[uuid]/delete/+page.svelte
sites/registry/static/robots.txt
sites/registry/svelte.config.js
sites/registry/tsconfig.json
sites/registry/vite.config.ts
src/functions/color.ts
tools/packager.ts
tsconfig.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

> [!CAUTION] > ## Review failed > > The pull request is closed.   <details> <summary>📝 Walkthrough</summary> ## Walkthrough Introduces a comprehensive web-based pack registry system under `sites/registry/` with PostgreSQL database, token-based authentication, REST API endpoints, and Svelte UI components. Updates root tooling to support 7zip compression and Bun's native ANSI stripping. ## Changes | Cohort / File(s) | Summary | |---|---| | **Root Configuration Updates** `.gitignore`, `biome.json`, `package.json`, `tsconfig.json` | Added packs archive patterns to gitignore; excluded sites directories from linter; updated dependencies (added 7zip-min, removed strip-ansi/typescript/generate-changelog); updated TypeScript config (esnext target, module preservation). | | **Tooling Updates** `src/functions/color.ts`, `tools/packager.ts` | Replaced strip-ansi with Bun.stripANSI; refactored packager to support 7zip compression, UUID-based pack identification, metadata discovery, and unpacking workflows. | | **Registry Site Configuration** `sites/registry/.env.example`, `.gitignore`, `.npmrc`, `.prettierignore`, `.prettierrc`, `compose.yaml`, `drizzle.config.ts`, `eslint.config.js`, `package.json`, `svelte.config.js`, `tsconfig.json`, `vite.config.ts` | Established project scaffolding with Docker Compose PostgreSQL setup, Drizzle ORM configuration, ESLint/Prettier styling rules, SvelteKit + Vite build tooling. | | **Database Schema & Server Utilities** `sites/registry/src/lib/db/schema.ts`, `src/lib/db/index.ts`, `src/lib/db/pack.ts`, `src/lib/db/comment.ts`, `src/lib/db/setting.ts` | Defined comprehensive Drizzle schema (users, sessions, packs, cards, comments, notifications); implemented data loaders with access control, like/dislike aggregation, and setting management. | | **Authentication & Authorization** `sites/registry/src/lib/server/auth.ts`, `src/lib/user.ts`, `src/lib/pack.ts` | Implemented token-based session management (generation, validation, renewal, cookie handling); added role-based access control helpers and pack/user censoring utilities. | | **API Routes: Authentication & Users** `sites/registry/src/routes/api/v1/user/login/+server.ts`, `register/+server.ts`, `[uuid]/+server.ts`, `sites/registry/src/routes/+page.server.ts` | Provided login/registration endpoints with Argon2 password hashing, user profile management with role changes and notifications, and logout handler. | | **API Routes: Pack Operations** `sites/registry/src/routes/api/v1/pack/[uuid]/+server.ts`, `upload/+server.ts`, `like/+server.ts`, `dislike/+server.ts` | Implemented pack CRUD (delete), file upload with 7z validation and archive inspection, pack like/dislike interactions with per-user state tracking. | | **API Routes: Pack Versions & Downloads** `sites/registry/src/routes/api/v1/pack/[uuid]/versions/[version]/+server.ts`, `approve/+server.ts`, `cards/+server.ts`, `download/+server.ts`, `files/+server.ts`, `files/[...path]/+server.ts` | Exposed version management (delete, approve with notifications), card listing, archive download with 7zip compression, and recursive file tree retrieval. | | **API Routes: Comments & Interactions** `sites/registry/src/routes/api/v1/pack/[uuid]/comments/+server.ts`, `[commentId]/+server.ts`, `[commentId]/like/+server.ts`, `[commentId]/dislike/+server.ts`, `[commentId]/heart/+server.ts` | Implemented paginated comment posting/deletion, like/dislike toggles, and heart (favorite) interactions with author notifications. | | **API Routes: Search & Notifications** `sites/registry/src/routes/api/v1/search/packs/+server.ts`, `cards/+server.ts`, `notifications/+server.ts`, `[uuid]/+server.ts`, `clear/+server.ts`, `feeds/packs/waiting-for-approval.xml/+server.ts` | Built search endpoints (packs/cards by name with pagination), notification fetch/delete/clear, and moderator RSS feed for approval queue. | | **Shared UI Components** `sites/registry/src/lib/components/badge.svelte`, `card-big.svelte`, `card-small.svelte`, `file-tree.svelte`, `pack-big.svelte`, `pack-small.svelte`, `user-big.svelte` | Created reusable Svelte components for cards, packs, users, file browsers, and badges with conditional rendering for metadata, stats, and moderation controls. | | **Page Routes: Authentication & Dashboard** `sites/registry/src/routes/login/+page.server.ts`, `+page.svelte`, `dashboard/**/+layout.server.ts`, `dashboard/packs/+page.svelte`, `dashboard/admin/settings/+page.svelte` | Provided login form with superforms validation, moderator/admin role guards, and dashboard shell pages. | | **Page Routes: Pack Detail & Versions** `sites/registry/src/routes/pack/[uuid]/+layout.server.ts`, `+page.server.ts`, `+page.svelte`, `versions/+page.svelte`, `versions/[version]/+layout.server.ts`, `versions/[version]/+layout.svelte`, `versions/[version]/+page.svelte`, `versions/[version]/files/+page.server.ts`, `versions/all/+page.server.ts` | Implemented pack detail pages with comment threads, version browsing, file tree exploration, like/dislike actions, and version deletion/approval workflows. | | **Page Routes: Card & User Profiles** `sites/registry/src/routes/card/[uuid]/+layout.server.ts`, `+page.svelte`, `versions/+page.svelte`, `versions/[version]/+page.svelte`, `user/[uuid]/+layout.server.ts`, `+page.server.ts`, `+page.svelte` | Created card detail pages with version history, and user profile pages showing packs and metadata with edit controls. | | **Page Routes: Search & Notifications** `sites/registry/src/routes/search/+page.server.ts`, `+page.svelte`, `notifications/+page.server.ts`, `+page.svelte`, `[uuid]/+page.server.ts` | Built search results page with packs/cards, and notifications listing with delete/clear actions. | | **Page Routes: Upload & Layout** `sites/registry/src/routes/upload/+page.server.ts`, `+page.svelte`, `+layout.server.ts`, `+layout.svelte`, `+page.svelte`, `app.d.ts`, `app.html`, `hooks.server.ts`, `layout.css` | Added pack upload form, global layout with navigation, user avatar display, notifications bell, search bar, and session middleware for auth/settings initialization. | | **Static Assets** `sites/registry/static/robots.txt` | Added SEO-friendly robots.txt allowing all user agents. | ## Sequence Diagram(s) ```mermaid sequenceDiagram actor User participant Client as Browser participant Server as SvelteKit Server participant DB as PostgreSQL participant FS as File System rect rgba(100, 200, 100, 0.1) note over User,FS: Pack Upload Flow User->>Client: Select .7z file Client->>Server: POST /api/v1/pack/[uuid]/upload (binary) Server->>Server: Validate magic bytes (7z) Server->>FS: Extract archive to temp dir Server->>Server: Validate archive contents (meta.jsonc, max files, size) Server->>Server: Parse metadata & cards Server->>DB: Check existing pack versions alt New Pack Server->>DB: Insert pack + cards records Server->>DB: Set isLatestVersion=true else Existing Pack (newer version) Server->>DB: Mark old versions isLatestVersion=false Server->>DB: Insert new pack + cards Server->>DB: Set new as isLatestVersion=true end Server->>FS: Move archive to static/assets/packs/ Server->>Client: Return 200 with pack metadata end rect rgba(100, 150, 200, 0.1) note over User,FS: Pack Approval Flow (Moderator) User->>Client: View waiting-for-approval feed Client->>Server: GET /api/v1/feeds/packs/waiting-for-approval.xml Server->>DB: Query packs WHERE approved=false Server->>Client: Return RSS feed User->>Client: Click approve on pack version Client->>Server: POST /api/v1/pack/[uuid]/versions/[version]/approve Server->>Server: Check moderator role Server->>DB: Update pack approved=true, approvedBy=userId Server->>DB: Cascade mark previous versions isLatestVersion=false Server->>DB: Create notifications for pack authors Server->>Client: Return 200 end rect rgba(200, 100, 100, 0.1) note over User,FS: Authentication Flow User->>Client: Submit login form Client->>Server: POST /api/v1/user/login Server->>DB: Query user by username alt User Not Found Server->>Client: 403 Forbidden else User Found Server->>Server: Verify password (Argon2) alt Password Invalid Server->>Client: 403 Forbidden else Password Valid Server->>Server: generateSessionToken() Server->>DB: createSession(token, userId) Server->>Client: Set auth-session cookie Server->>Client: 200 with user data end end end ``` ## Estimated code review effort 🎯 5 (Critical) | ⏱️ ~120 minutes ## Possibly related issues - `#427`: Directly implements the "Add npm-like registry for packs" feature with database schema, authentication, pack/card management, search, upload/download, moderation tools, and approval workflows. ## Possibly related PRs - `#438`: Both PRs modify `tools/packager.ts` to handle 7zip-based pack discovery, import/export, and compression workflows. ## Suggested labels `scope: feature` --- > 🐰 *A registry is born, with cards and packs so fine,* > *Users upload their creations, moderation makes them shine,* > *Comments flow and hearts abound, versions tagged with care,* > *From database to interface, a marketplace so fair!* </details>   <details> <summary>✨ Finishing touches</summary> - [ ]  📝 Generate docstrings <details> <summary>🧪 Generate unit tests (beta)</summary> - [ ]  Create PR with unit tests - [ ]  Post copyable unit tests in a comment - [ ]  Commit unit tests in branch `registry` </details> </details>  --- <details> <summary>📜 Recent review details</summary> **Configuration used**: defaults **Review profile**: CHILL **Plan**: Pro <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 89102c8f364cb5b561fa7104cbd463e12a4be4c7 and 34fec4be0bd9f9fb6da953f5fdc4ce742305e328. </details> <details> <summary>⛔ Files ignored due to path filters (3)</summary> * `bun.lock` is excluded by `!**/*.lock` * `sites/registry/bun.lock` is excluded by `!**/*.lock` * `sites/registry/src/lib/assets/favicon.svg` is excluded by `!**/*.svg` </details> <details> <summary>📒 Files selected for processing (108)</summary> * `.gitignore` * `biome.json` * `package.json` * `sites/registry/.env.example` * `sites/registry/.gitignore` * `sites/registry/.npmrc` * `sites/registry/.prettierignore` * `sites/registry/.prettierrc` * `sites/registry/README.md` * `sites/registry/compose.yaml` * `sites/registry/drizzle.config.ts` * `sites/registry/eslint.config.js` * `sites/registry/package.json` * `sites/registry/src/app.d.ts` * `sites/registry/src/app.html` * `sites/registry/src/hooks.server.ts` * `sites/registry/src/lib/api/schemas.ts` * `sites/registry/src/lib/api/types.ts` * `sites/registry/src/lib/components/badge.svelte` * `sites/registry/src/lib/components/card-big.svelte` * `sites/registry/src/lib/components/card-small.svelte` * `sites/registry/src/lib/components/file-tree.svelte` * `sites/registry/src/lib/components/pack-big.svelte` * `sites/registry/src/lib/components/pack-small.svelte` * `sites/registry/src/lib/components/user-big.svelte` * `sites/registry/src/lib/db/schema.ts` * `sites/registry/src/lib/index.ts` * `sites/registry/src/lib/pack.ts` * `sites/registry/src/lib/server/auth.ts` * `sites/registry/src/lib/server/db/comment.ts` * `sites/registry/src/lib/server/db/index.ts` * `sites/registry/src/lib/server/db/pack.ts` * `sites/registry/src/lib/server/db/setting.ts` * `sites/registry/src/lib/user.ts` * `sites/registry/src/routes/+layout.server.ts` * `sites/registry/src/routes/+layout.svelte` * `sites/registry/src/routes/+page.server.ts` * `sites/registry/src/routes/+page.svelte` * `sites/registry/src/routes/api/v1/feeds/packs/waiting-for-approval.xml/+server.ts` * `sites/registry/src/routes/api/v1/notifications/+server.ts` * `sites/registry/src/routes/api/v1/notifications/[uuid]/+server.ts` * `sites/registry/src/routes/api/v1/notifications/clear/+server.ts` * `sites/registry/src/routes/api/v1/pack/[uuid]/+server.ts` * `sites/registry/src/routes/api/v1/pack/[uuid]/comments/+server.ts` * `sites/registry/src/routes/api/v1/pack/[uuid]/comments/[commentId]/+server.ts` * `sites/registry/src/routes/api/v1/pack/[uuid]/comments/[commentId]/dislike/+server.ts` * `sites/registry/src/routes/api/v1/pack/[uuid]/comments/[commentId]/heart/+server.ts` * `sites/registry/src/routes/api/v1/pack/[uuid]/comments/[commentId]/like/+server.ts` * `sites/registry/src/routes/api/v1/pack/[uuid]/dislike/+server.ts` * `sites/registry/src/routes/api/v1/pack/[uuid]/like/+server.ts` * `sites/registry/src/routes/api/v1/pack/[uuid]/upload/+server.ts` * `sites/registry/src/routes/api/v1/pack/[uuid]/versions/[version]/+server.ts` * `sites/registry/src/routes/api/v1/pack/[uuid]/versions/[version]/approve/+server.ts` * `sites/registry/src/routes/api/v1/pack/[uuid]/versions/[version]/cards/+server.ts` * `sites/registry/src/routes/api/v1/pack/[uuid]/versions/[version]/download/+server.ts` * `sites/registry/src/routes/api/v1/pack/[uuid]/versions/[version]/files/+server.ts` * `sites/registry/src/routes/api/v1/pack/[uuid]/versions/[version]/files/[...path]/+server.ts` * `sites/registry/src/routes/api/v1/search/cards/+server.ts` * `sites/registry/src/routes/api/v1/search/packs/+server.ts` * `sites/registry/src/routes/api/v1/user/[uuid]/+server.ts` * `sites/registry/src/routes/api/v1/user/login/+server.ts` * `sites/registry/src/routes/api/v1/user/register/+server.ts` * `sites/registry/src/routes/card/[uuid]/+layout.server.ts` * `sites/registry/src/routes/card/[uuid]/+page.svelte` * `sites/registry/src/routes/card/[uuid]/versions/+page.svelte` * `sites/registry/src/routes/card/[uuid]/versions/[version]/+page.svelte` * `sites/registry/src/routes/dashboard/+layout.server.ts` * `sites/registry/src/routes/dashboard/+layout.svelte` * `sites/registry/src/routes/dashboard/admin/+layout.server.ts` * `sites/registry/src/routes/dashboard/admin/settings/+page.svelte` * `sites/registry/src/routes/dashboard/packs/+page.svelte` * `sites/registry/src/routes/layout.css` * `sites/registry/src/routes/login/+page.server.ts` * `sites/registry/src/routes/login/+page.svelte` * `sites/registry/src/routes/notifications/+page.server.ts` * `sites/registry/src/routes/notifications/+page.svelte` * `sites/registry/src/routes/notifications/[uuid]/+page.server.ts` * `sites/registry/src/routes/pack/[uuid]/+layout.server.ts` * `sites/registry/src/routes/pack/[uuid]/+page.server.ts` * `sites/registry/src/routes/pack/[uuid]/+page.svelte` * `sites/registry/src/routes/pack/[uuid]/comments/+page.server.ts` * `sites/registry/src/routes/pack/[uuid]/comments/[commentId]/+page.server.ts` * `sites/registry/src/routes/pack/[uuid]/edit/+page.svelte` * `sites/registry/src/routes/pack/[uuid]/versions/+page.svelte` * `sites/registry/src/routes/pack/[uuid]/versions/[version]/+layout.server.ts` * `sites/registry/src/routes/pack/[uuid]/versions/[version]/+layout.svelte` * `sites/registry/src/routes/pack/[uuid]/versions/[version]/+page.server.ts` * `sites/registry/src/routes/pack/[uuid]/versions/[version]/+page.svelte` * `sites/registry/src/routes/pack/[uuid]/versions/[version]/files/+page.server.ts` * `sites/registry/src/routes/pack/[uuid]/versions/[version]/files/[...path]/+page.server.ts` * `sites/registry/src/routes/pack/[uuid]/versions/[version]/files/[...path]/+page.svelte` * `sites/registry/src/routes/pack/[uuid]/versions/all/+page.server.ts` * `sites/registry/src/routes/pack/[uuid]/versions/all/+page.svelte` * `sites/registry/src/routes/search/+page.server.ts` * `sites/registry/src/routes/search/+page.svelte` * `sites/registry/src/routes/upload/+page.server.ts` * `sites/registry/src/routes/upload/+page.svelte` * `sites/registry/src/routes/user/[uuid]/+layout.server.ts` * `sites/registry/src/routes/user/[uuid]/+page.server.ts` * `sites/registry/src/routes/user/[uuid]/+page.svelte` * `sites/registry/src/routes/user/[uuid]/delete/+page.svelte` * `sites/registry/static/robots.txt` * `sites/registry/svelte.config.js` * `sites/registry/tsconfig.json` * `sites/registry/vite.config.ts` * `src/functions/color.ts` * `tools/packager.ts` * `tsconfig.json` </details> </details>  --- Thanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=LunarTides/Hearthstone.js&utm_content=434)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. <details> <summary>❤️ Share</summary> - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code) </details> Comment `@coderabbitai help` to get the list of available commands and usage tips.

LunarTides commented

2025-12-17 07:05:29 +00:00

(Migrated from github.com)

I need to do some cleaning up and resolving todo comments, since there's a lot. Duplicate code, lack of consistent i18n, bugs gallore, etc... I'm surprised this only adds ~4.5k loc with this level of quality. Then again, fixing these issues might cause the loc to spike, not that it matters too much...

Either way, none of this code can be shipped as is. The potential for bugs is way too high.

I need to do some cleaning up and resolving todo comments, since there's a *lot*. Duplicate code, lack of consistent i18n, bugs gallore, etc... I'm surprised this only adds ~4.5k loc with this level of quality. Then again, fixing these issues might cause the loc to spike, not that it matters too much... Either way, *none* of this code can be shipped as is. The potential for bugs is *way* too high.

LunarTides commented

2025-12-26 11:52:51 +00:00

(Migrated from github.com)

Merging so that I can deploy to Vercel. See #443

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

LunarTides/Hearthstone.js!434

No description provided.

Rows
Columns